internal: remove obsolete rsemWarnUnsafeCode
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The removal is good, thanks. Could you shorten the PR title and clean up the PR message a bit? |
zerbina
added
compiler
bung87
changed the title
rsemWarnUnsafeCode, proc cstringCheckrsemWarnUnsafeCode
zerbina
changed the title
rsemWarnUnsafeCodersemWarnUnsafeCode
|
I've made a small change to the title, and also restructured/extended the PR body a bit. |
|
/merge |
|
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
cstringCheckprocedure, together with thersemWarnUnsafeCodewarning.Details
The warning was only produced by the
cstringCheckprocedure, to whichthe only call was disabled. Checking for unsafe cstring conversions is
already performed in
sempass2.track, so the unusedcstringCheckcanbe safely removed.